If it's not legitimate, how should I have written the test & code below?

use strict;
use warnings;
use Test::More;
use FindBin qw( $RealBin );
use lib $RealBin;

use MyModule;

if (connected()) {
    pass("\"connected\" works with defaults ($^O)");
} else {
    plan skip_all => 'Internet inaccessible';
}

my $careto = $^O;

if ($careto =~ /win/gmsi) {
    $^O = 'linux';
} else {
    $^O = 'win';
}

ok !connected(), "\"connected\" fails with defaults overwritten ($^O)"
    or diag("\"connected\" returns true regardless (OS = $^O)");

$^O = $careto;

done_testing;

[download]

SSCCE (I hope!) from the module:

Package MyModule;

use strict;
use warnings;

sub connected {
    my $pingcmd = 'ping -c 1 8.8.8.8';
    my $pingworks = ' 0% packet loss';
    if ($^O =~ /win/gmsi) {
        $pingcmd =~ s/-c/\/n/;
        $pingworks = 'bytes=32';
    }
    my $pingrtn = qx($pingcmd);
    return $pingrtn =~ /$pingworks/msi;
}

1;

[download]

I accept this may be an ugly hack, but it tests what I want in a way that seems obvious to me. But I will gladly accept improvements, advice and explanations.

Regards,

John Davies

Almost immediate update: deleted a couple of relic lines

In reply to Re: Is it ever legitimate to override $^O ? by davies
in thread Is it ever legitimate to override $^O ? by syphilis

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.