Using an array of integers as input my task is to test each integer to see if the sum of its digits is odd. The integers passing this test are to be printed out in horizontal line with a space between each integer so as to be human readable. The test must work for positive and negative integers.

I decided to put the test into a subroutine. My code appears to work. My question is whether it is optimal by the standards of the proficient Perl programmer or whether it is just a newbie hack. As an example, I have used the absolute value function abs but I could have used abs($_). Which is best? Does it matter?

my @input = ( -222, -221, -21, 0, 1, 1, 2, 3, 5, 8, 13, 21, 34, 55, 89
+, 144 );

sub oddDigitSum {
    my @ans;
    for (@_) {
        my @digits = split //, abs;
        my $sum;
        $sum += $_ for @digits;
        $sum % 2 && push @ans, $_;
    }
    return @ans;
}
print $_, " " for oddDigitSum(@input);
print “\n”;

[download]

In reply to Newbie question by oldB51

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.