G'day oldB51,

Don't write "My code appears to work." and leave us to verify it; show your output. It didn't work for me because:

$ perl -e 'print “\n”;'
Unrecognized character \xE2; marked by <-- HERE after print <-- HERE n
+ear column 7 at -e line 1.
[download]

Using a subroutine is usually a good thing. It abstracts your code so it can be reused within your script. If you find it's particularly useful, you can put it in a module and many scripts can reuse it.

There are many functions whose default argument is $_. Writing abs instead of abs($_) is absolutely fine. Pun intended. :-)

Aim for readability and maintainability. The following might look clever but, for many, it would be difficult to understand; it's not easy to modify; and, it can't be reused.

#!/usr/bin/env perl

use strict;
use warnings;

use List::Util 'sum';

my @input = qw{-222 -221 -21 0 1 1 2 3 5 8 13 21 34 55 89 144};

print join(' ', map +(sum(split //, abs) % 2 ? $_ : ()), @input), "\n"
+;
[download]

Output:

-221 -21 1 1 3 5 21 34 89 144
[download]

Always use the strict and warnings pragmata. You may get one or both of those for free, with different values of VERSION, if you "use VERSION;". Some modules also do this for you.

I would also recommend that you unpack @_ at the start of your subroutines. There are other variables that you should deal with as soon as they become available; for example, $@ containing errors; $1, $2, and so on from regex matches; etc. There are various things that can change their values, perhaps not in the code when first written, but via insidious bugs that might be introduced following modifications. The following would've been better:

sub oddDigitSum {
    my (@nums) = @_;
    my @ans;
    for (@nums) {
    ...
[download]

Of course, all of the above are my opinions. Others may have different opinions. Form you own opinions as your experience grows. :-)

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.