hi
Party of the first part? Smart quotes snuck in your post;)
compare to yours, what did i change?
use strict; use warnings; my @input = ( -222, -221, -21, 0, 1, 1, 2, 3, 5, 8, 13, 21, 34, 55, 89, 144 ); print $_, " " for oddDigitSum(@input); print "\n"; exit 0; sub oddDigitSum { my @ans; for my $int (@_) { my @digits = split //, abs $int; my $sum = 0; $sum += $_ for @digits; $sum % 2 and push @ans, $int; } return @ans; }
compare to yours, and mine, what did i change?
use strict; use warnings; my @input = ( -222, -221, -21, 0, 1, 1, 2, 3, 5, 8, 13, 21, 34, 55, 89, 144 ); print $_, " " for oddDigitSum(@input); print "\n"; exit 0; sub oddDigitSum { my @ans; for my $int (@_) { my $sum = 0; $sum += $_ for split //, abs $int;; $sum % 2 and push @ans, $int; } return @ans; }
compare to yours, and mine, and mine, what did i change? Is it better? Simpler? Clearer? New and unfamiliar? Ambiguous? Faster?
use strict; use warnings; my @input = ( -222, -221, -21, 0, 1, 1, 2, 3, 5, 8, 13, 21, 34, 55, 89, 144 ); print $_, " " for oddDigitSum(@input); print "\n"; exit 0; sub oddDigitSum { my @ans; for my $int (@_) { my $sum = Summ( split //, abs $int );; $sum % 2 and push @ans, $int; } @ans; } sub Summ { my $sum = 0; $sum+=$_ for @_; $sum; }
I'm typing this on my phone. Seent map yet? I've seent it :) is it ...?
use strict; use warnings; my @input = ( -222, -221, -21, 0, 1, 1, 2, 3, 5, 8, 13, 21, 34, 55, 89, 144 ); print $_, " " for oddDigitSum(@input); print "\n"; exit 0; sub oddDigitSum { my @ans = map { my $sum = Summ( split //, abs $_ );; $sum % 2 ? $_ # keep oddities : () ; } @_; @ans; } sub Summ { my $sum = 0; $sum+=$_ for @_; $sum; }
I'm typing this on my phone. Seent map yet? I've seent it :) is it ...?
use strict; use warnings; my @input = ( -222, -221, -21, 0, 1, 1, 2, 3, 5, 8, 13, 21, 34, 55, 89, 144 ); print $_, " " for oddDigitSum(@input); print "\n"; exit 0; sub oddDigitSum { map { my $sum = 0; $sum+=$_ for split //, abs $_ ;; $sum % 2 ? $_ # keep oddities : () ; } @_; }
im sleepy
there is discussion of things like this, but I'm away from my keyboard and my links, so these search terms are a reminder to me to follow up on this question
on Naming variables use $_....define best, what best, readability, idiomatic, modern Perl, local $_, reuse var
In reply to Re: Newbie question (code review using $_ naming variables best practice etc)
by Anonymous Monk
in thread Newbie question
by oldB51
| For: | Use: | ||
| & | & | ||
| < | < | ||
| > | > | ||
| [ | [ | ||
| ] | ] |