There is a lot in your script which I would do differently and there is a lot in there which is irrelevant for your problem. However, this SSCCE shows that the logic in your loop, however inefficient, does create a match.

#!/usr/bin/perl
use strict;
use warnings;

my $user = 'foo';
my $pass = 'bar';
my @upd  = (
    'abc|abc|xyz|xyz',
    'foo|bar|xyz|xyz',
    'baz|quux|xyz|xyz'
);
my $good = 0;

foreach my $line (@upd)   {
    my ($d_line) = split (/\n/, $line);
    my ($username, $password, $user_pass, $active) = split (/\|/, $d_l
+ine);
    print "Testing '$username' and '$password'\n";
    next if $username ne $user;
    $good = 1 if $username eq $user and $password eq $pass;
}

print "Good is '$good', should be '1'\n";

[download]

This suggests that either you are not processing the form fields correctly or as has already been suggested you are not filling the @upd array correctly (or it doesn't contain what you think it does).

Notice how I've used strict and warnings - they are there to help. See the rest of the Basic Debugging Checklist for more ways to help solve your problem.

🦛

In reply to Re: amateur at Perl need help with small script by hippo
in thread amateur at Perl need helpwith small script by jpys

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.