I also spent some time reviewing a colleague's >10KLOC shell application, during which my most repeated (verbal) review comment was ".. and at what point did you realise that writing this in shell was a really stupid idea?"

I feel your pain. Sounds like he got you to review the code after it was "done". Is that right? If so, it looks like an example of the classic Beware of a guy in a room anti-pattern. He should have been discussing the general approach with the team long before going off to create his shell script monstrosity.

I see this was back in 2008-2009. I trust this sort of dysfunctional teamwork would not occur at Google today, given their seminal gTeams study of 2015/2016 (discussed at Working Solo and in a Team and Psychological Safety).

After being burned by a number of similar incidents, I had a rare success at work, managing to persuade all of R&D to stop writing Unix shell (and Windows BAT) monstrosities, based on the arguments put forward in Unix shell versus Perl.


In reply to Re^2: Google considers Perl a useful skill by eyepopslikeamosquito
in thread Google considers Perl a useful skill by reisinge

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.