I think he'd been looking for someone prepared to review it for quite a while. The team was split across Mountain View and Dublin (with Dublin the smaller and very much the junior part), and this was during my initial visit to Mountain View shortly after I joined. I suspect getting me to review it was intended as a kind of hazing of the newbie, but I didn't actually mind it at all since I'm a big fan of code review and considered it comfortably within my competency.

This being SRE most of them had a primary background in system administration with a sideline of programming rather than the other way round as in my case, so writing a big bunch of shell may not have seemed an entirely unnatural choice. Within the context of multi-KLOC shell applications, it was actually pretty well written - I learned quite a bit about shell programming in the process. But of course I can has perl, so I've since forgotten it all again. :)


In reply to Re^3: Google considers Perl a useful skill by hv
in thread Google considers Perl a useful skill by reisinge

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.