My app was taking 5 seconds to generate an image involving about a million calls to Imager->setpixel and this felt way too slow.
NYTProf revealed the cause to be expensive sanity checking in
Imager.pm at lines 3456 and 3465. Commenting those lines gets me down to 3 seconds and this now feels much less slow:
sub setpixel {
my ($self, %opts) = @_;
# $self->_valid_image("setpixel") or return;
my $color = $opts{color};
unless (defined $color) {
$color = $self->{fg};
defined $color or $color = NC(255, 255, 255);
}
# unless (ref $color && UNIVERSAL::isa($color, "Imager::Color")) {
# unless ($color = _color($color, 'setpixel')) {
# $self->_set_error("setpixel: " . Imager->errstr);
# return;
# }
# }
unless (exists $opts{'x'} && exists $opts{'y'}) {
$self->_set_error('setpixel: missing x or y parameter');
return;
}
...
}
sub _valid_image {
my ($self, $method) = @_;
ref $self
or return Imager->_set_error("$method needs an image object");
$self->{IMG} && Scalar::Util::blessed($self->{IMG}) and return 1;
my $msg = $self->{IMG} ? "images do not cross threads" : "empty inpu
+t image";
$msg = "$method: $msg" if $method;
$self->_set_error($msg);
return;
}
Should the next version of
Imager have an option to disable global sanity so it can operate almost twice the usual speed?
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.