Q2) Do we live in a post CGI-bin world? This looks pretty ancient to be worried about buffers.

The author of that code has chosen to be worried about buffers and that is therefore his concern. He could instead have chosen to use something like CGI::UploadEasy and not given two hoots about buffers. Personally I wouldn't worry about the use of a buffer either way. I would be more concerned about not checking the result of open(), printing out plain text in a text/html MIME type response, indenting oddly/inconsistently, using an unreferenced label and some quaint old-time syntax. :-)

🦛

In reply to Re: Using perl to script an upload page by hippo
in thread Using perl to script an upload page by Aldebaran

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.