G'day beaker121,

Welcome to the Monastery.

You'll need to show us the code where these global variables are defined; or, at least, a small extract of that code such that we can understand what is going on. Your prosaic description is unclear. Your posted code does not reference any global variables.

[Aside: I appreciate that this is your first post, so you probably didn't know about this, but please see "What shortcuts can I use for linking to other information?". As an example, writing vars::global, instead of just vars::global, makes referencing modules you're discussing a lot easier.]

By the way, "return $self->{$name} || '';" looks dodgy. If the actual value was zero, did you really want to report it as a zero-length string. I don't know enough about your code, but suspect exists() and/or defined() might be useful here.

— Ken


In reply to Re: Best Practice for Replacing Globals by kcott
in thread Best Practice for Replacing Globals by beaker121

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.