As the new module is pretty much written I have thrown it at Perl Critic which has detected a couple of issues. But as I have wound up the severity, it seems a little silly...

How critical is it that code destined for CPAN passes critic, if at all?
And what severity level would be sensible?

I was surprised it didn't like this use of eval: 

our $VERSION = '0.1_1';
$VERSION = eval $VERSION;

[download]
and I struggle to see what benefit adding the /x flag would be to such a simple regular expression: 
my @embed = split /,/, $embed_string;

[download]
With a higher severity, it wants me to add lots of flags - /xms - to this!

The one where I want to change it but can't quite see a better way to write it without losing clarity is this: 

# Create Embedding object
sub new {
    my $class = shift;
    my %attr  = @_;

    # ......

}

[download]
Critic says I should unpack @_ on the first line but is it really that bad to split it across two consecutive lines? There would be a problem if it was part way through the sub but it is clear what is going on and there is no chance of the modifying the wrong thing through an alias.

Am I missing some lurking danger here?

In reply to How Critical is Critic? by Bod

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.