Any automated code analysis will fail for lots of edge cases, sometimes in really amusing ways and other times in just plain dumb ways. Experience and context is almost always the key to figuring out if the analysis is telling you something important or not. The key phrase from your introduction is "which has detected a couple of issues" so that's a win.

For the rest, if it doesn't make sense to you you can most likely safely ignore it: you have the experience and know the context. For the unpacking @_ "issue", I'd write it as:

# Create Embedding object sub new { my ($class, %attr) = @_;

But that's how I'd have written it in the first instance and maybe that makes your eyes bleed, so what do I know? Either version works in terms of clarity in my view. I guess what the rule is really trying to clean up is progressive unpacking of the argument list through the function making the expected function signature hard to determine. That isn't an issue with your version so I'd say no problem exists.

Optimising for fewest key strokes only makes sense transmitting to Pluto or beyond

In reply to Re: How Critical is Critic? by GrandFather
in thread How Critical is Critic? by Bod

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.