As others have said, perlcritic is opinionated (and intentionally so). Use the parts you agree with and ignore the parts you don't.

I struggle to see what benefit adding the /x flag would be to such a simple regular expression

There isn't any, so ignore it. FWIW, I literally never use /x as it causes more problems than it solves for me. YMMV.

How critical is it that code destined for CPAN passes critic, if at all?

Not at all. perlcritic is a tool for the author only to ensure that they have followed their own choice of policies (or more usually policies enforced upon them by someone else). Upload dists which pass, upload dists which don't - it makes no odds.

All that said, I am curious as to why you use the string eval in that context at all. Can you explain what it is doing that a simple scalar assignment won't achieve?

🦛

In reply to Re: How Critical is Critic? by hippo
in thread How Critical is Critic? by Bod

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.