I agree. You have to customize Perl::Critic to your own requirements. For example, i have upped the "maximum complexity score" and "maximum length of functions" of some parts of my code quite a bit. When you write complex state machines that (for example) handle HTTP connections. the main state machine winds up to be quite long. Yes, i could split that up into more functions, but in my case it would hinder readability and up the mental complexity while debugging.

Perl::Critic is certainly a helpful tool. But only after adapting it to the projects requirements and coding style. Plus, P::C regularly behaves stupid when new Perl features come out.

It's also important to remember that P::C only does static analysis. But only you can prevent forest fires the perl interpreter can properly parse Perl. And some P::C recommendations might even go against project/company policies.

PerlMonks XP is useless? Not anymore: XPD - Do more with your PerlMonks XP

In reply to Re^2: How Critical is Critic? by cavac
in thread How Critical is Critic? by Bod

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.