I guess that's a consequence of $! being localized rather early: You pass $!... which is available as an alias in Carp::croak. By localizing $!, it also masks the value you passed to the subroutine.

Demo:

use 5.032;
sub foo {
    local $!;
    my $err = shift;
    say "foo found: '$err'";
}
sub bar {
    my $err = shift;
    local $!;
    say "bar found: '$err'";
}
open (my $foo, '<', 'doesnotexist.dat') or foo($!);
open (my $bar, '<', 'doesnotexist.dat') or bar($!);

[download]

Output:

foo found: ''
bar found: 'No such file or directory'

[download]

In foo, your $! gets clobbered by localizing. If you quote it, you've already copied the string value of $!, so it doesn't matter that it gets localized afterwards.

In reply to Re: Carp: $! vs "$!" in croaking by haj
in thread Carp: $! vs "$!" in croaking by cavac

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.