You should post an SSCCE instead of vague excerpts of what you think are the relevant parts of your program.

In the problematic part of your program, you show:

while ($STPU eq 'good')  {

[download]

So, when does $STPU ever get to ne 'good' ? Think about this.

For your "slow" script, consider to do the database updates for more than one row maybe?

Without seeing what takes the time, it's really hard to tell what goes wrong.

My approach given the bad information you gave would be to loop up to 10 times in the "bad" program:

my $count = 0;
while ($STPU eq 'good' and $count++ < 10 ) {
...
}

[download]

This does a maximum of 10 changes.

In reply to Re: looping safely by Corion
in thread looping safely by frank1

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.