Hi monks,

I am writing a program to calculate changes and reformat a particular file. I have it working. I am already using subroutines to calculate the different values depending on the type of data on a given line. I noticed that many of the subroutines contain partly overlapping code.

Should I make a new level of subroutines to have less repeating code? (In other words, my subroutines would have subroutines.) It seems that might be more confusing to decipher later. Which way would be more efficient running the program? Or would it matter at all?

I am interested not just in this program, but in the general questions. How do you know when a program or subroutine is too long and would be better broken up? How should I use subroutines to make my programs more efficient?

Thanks in advance for your advice.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.