Should I make a new level of subroutines to have less repeating code? (In other words, my subroutines would have subroutines.) It seems that might be more confusing to decipher later.

If you name your (sub)subroutines well, to reflect what they do in the context of the callers, it can often greatly clarify things

Which way would be more efficient running the program?

You do pay a performance penalty for calling a subroutine. In any language, but usually more so in interpreted languages.

Or would it matter at all?

Whether the reduction in maintenance -- of not having to change (and remember to change) all the copies of similar code -- and the clarity and greater readability that can come from having smaller subs; thus less code to deal with at any given time -- is worth the performance cost -- is very much down to how critical performance is to your program.

If your program runs for a few minutes a couple of extra seconds don't matter much. If your program runs for hours and the extra subroutines add another hour or two; you might reconsider the balance.

If your program is IO-bound: eg waits for the user to fill in a web form; a few seconds might not matter too much; but a couple of minutes might loose you business.

Only you can know your application well enough to know the right answer to that question.


With the rise and rise of 'Social' network sites: 'Computers are making people easier to use everyday'
Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
"Science is about questioning the status quo. Questioning authority". I'm with torvalds on this
In the absence of evidence, opinion is indistinguishable from prejudice. Agile (and TDD) debunked

In reply to Re: efficient use of subroutines by BrowserUk
in thread efficient use of subroutines by jeri_rl

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.