I am not very experienced with perl, but I know enough that this looks pretty bad 
$dbh->begin_work;
my $href = $dbh->selectall_hashref("SELECT * FROM data WHERE ToScan IS
+ NULL AND title IS NOT NULL limit 1 FOR UPDATE SKIP LOCKED", "someid"
+);
foreach my $tmp (keys %$href) {
   $ID=$href->{$tmp}->{'id'}; 
   $title=$href->{$tmp}->{'title'};
   $channel=$tmp; 
}
my $rsth=$dbh->prepare("UPDATE data SET lock=1 WHERE id='$ID'"); $rsth
+->execute() || die $rsth->errstr;
$dbh->commit;

[download]
is there any cleaner way of doing this? I need to "...FOR UPDATE" then get the ID of selected row to set a lock on it. My code works but is very ugly. Thank you

In reply to I wrote a very ugly piece of code, can someone help me correct it? by glwa

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.