I found out that I left some unaltered code that I programmed 10 years ago and it went unnoticed. I knew this bug and I actually fixed it quick and dirty in multiple places but I never found a good fix for it.

What is the best way to use the splice inside of a loop like this (foreach, or other)

Original code bugged:

sub filterExclude{ 
   my $ar = $_[0] ;   # REF!
   my $someConfig  = $_[1] ;
   my $ix = 0 ;
   foreach ( @{$ar} ) {
      my $sKey = $_ ;
      if ( exists ( $someConfig ->{ $sKey }->{ Exclude} ) && $someConf
+ig ->{ $sKey }->{ Exclude} ) {
         splice ( @{$ar}, $ix, 1 ) ;
         $ix = $ix - 1 ;
      }
      $ix = $ix + 1 ;
   }
}

[download]

Right now I have:

sub filterExclude{
   # 20240414 Quick fix needed because of the splice
   my $ar = $_[0] ;   # REF!
   my $someConfig  = $_[1] ;
   my $tmpCheckedEverything = 0 ;
   while ( !($tmpCheckedEverything) ) {
      $tmpCheckedEverything = 1 ;
      my $ix = 0 ;
      foreach ( @{$ar} ) {
         my $sKey = $_ ;
         if ( exists ( $someConfig ->{ $sKey }->{ Exclude} ) && $someC
+onfig ->{ $sKey }->{ Exclude} ) {
            splice ( @{$ar}, $ix, 1 ) ;
            $tmpCheckedEverything = 0 ;
         }
         $ix = $ix + 1 ;
      }
   }

[download]

But of course this is ugly and not efficient

In reply to How to use a splice inside a foreach by Veltro

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.