I am working with several flat file databases, pulling info out of them and generating reports in HTML. I have been count the number of entries in each file, and if there are no entries, want to display a page stating that there are no entries for that file. I've written the script to do this, but if the script opens a file with no entries, the script fails. Can anyone tell me what I'm doing wrong here? Here is a snippet of my code:
$lines = 0;
open (DATABASE, "$filename" || &ErrorMessage);       
    while (sysread DATABASE, $buffer, 4096) {        
        $lines += ($buffer =~ tr/\n//);
    }
close(DATABASE);    
if ($lines == 0){
   &NoReport;
}

sub NoReport {
   print "Content-type: text/html\n\n";
   print<<EOL;
<html>
<head>
<title>No Report</title>
</head>
<body bgcolor="white">
<h2>
No information has been submitted for the report you have requested.
</h2>
</body>
</html>
EOL
exit;
}

[download]

I probably just overlooked something simple. Thanks for your time.

In reply to subroutine not working by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.