Some operations can be shortened even further. It is up to the reader to decide if that increases or decreases maintainability :)

sub match_url {
    my $row = shift;         # No @_ required, that is the default
    my @matches = ($row =~ m/$re/g) or return;
    # do something with @matches
    }

if (!@ARGV or $ARGV[0] eq "-") {
    chomp (@ARGV = <STDIN>); # chomp can be done in one go
    match_url ($_) for @ARGV; # Your match_url takes one arg, not a li
+st
    }
else {
    # Do I need to handle the error case with this syntax?
    while (<>) {
        chomp $_; # Is chomp really needed? match_url probably ignores
+ trailing EOL in $re
        match_url ($_);
        }
    }

[download]

for vs while

($str =~ m/$re/g) (note the parens) returns all matches in one list

use 5.012003;
use warnings;

my $str = "abacadabra";
my $rex = qr{(a\w)};

say "-- say";
say for ($str =~ m/$rex/g);

say "-- while";
while ($str =~ m/$rex/g) {
    say $1;
    }

->

-- say
ab
ac
ad
ab
-- while
ab
ac
ad
ab

[download]

Enjoy, Have FUN! H.Merijn

In reply to Re^3: Use global flag when declaring regular expressions with qr? by Tux
in thread Use global flag when declaring regular expressions with qr? by unmatched

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.