ALWAYS use use strict; use warnings;!

use v5.14; has the side effect of doing use strict;, so that's good.

But use warnings; is missing. And using it would have caught some errors in your program.

The arguments being passed to fib make no sense.

You should originally pass the first and second terms (0 and 1), but you don't do that.

On the second pass, you should pass the second and third terms, but you don't do that either.

my $increment = @_; doesn't do what you think it does. An array in scalar context produces the number of elements in the array. You want 

# `my ( ... ) = ...` evaluates the RHS in list context.
my ( $increment ) = @_;

[download]
or 
# `shift` is short for `shift( @_ )`
my $increment = shift;

[download]

The program should output complete lines. 

print $result;

[download]
should be 
print "$result\n";

[download]
or 
say $result;

[download]

This is just a style thing, but 

$result += $increment;

[download]

is cleaner than 

$result = $result + $increment;

[download]

as Fletch pointed out.

Another style thing: 4000000 can also be written as 4_000_000.

In reply to Re: How am i doing? by ikegami
in thread How am i doing? by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.