There are a few problems with this code, mostly revealed by running clang's address sanitizer on it.

One is that the taking the negative of the most negative number expressible on a 2's complement box yields undefined behavior. The solution is to instead always do -(t + 1) + 1U That works for all negative values

Second is that the code assumes that this is a 2's complement machine. You rarely find a 1's complement these days, so this isn't a major issue. But it is trivial to avoid it. To get the lsb use  t & (~t + 1);

Finally, it is undefined behavior to left shift a negative number, which it could be since you've declared last_set to not be unsigned, and the top bit could be 1

In reply to Re^2: Detecting whether UV fits into an NV by khw
in thread Detecting whether UV fits into an NV by syphilis

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.