This blog by MJD changed how I feel when I see what seems at first to me like crazy bad code. Give the people who wrote what's already in place the benefit of the doubt. They may simply have landed on an inelegant approach to solving a more difficult set of issues than you're considering. Early on, learn about what is in place, why it is there, what decisions led to it, and how it solves the problems that you may not be weighing yet.

Only after you've taken the time to fully understand the thought process that led to the code you now see will you be able to maximize your own contributions. And at that point hopefully your patience and open mindedness will have won the respect of your team.


Dave

In reply to Re: Advice on best practices by davido
in thread Advice on best practices by goldcougar

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.