We are talking about integer factorisation?! Can't be calculated without a quantum computer.

Plus your code could endless loop.
$c -= 4096 while $c % $r && $c > 0;

One good solution is to use a lookup table.

use Fcntl; # For O_RDWR, O_CREAT, etc. use SDBM_File; # 0666 reduced by umask. tie my%__intfactor, 'SDBM_File','/var/tmp/intfactor.sdbm', O_RDWR|O_CREAT, 0666) or { warn"Couldn't tie SDBM file '/var/tmp/intfactor.sdbm': $!"; warn"continuing with ramdb"; }; sub intfactor() { exists $__intfactor{%r} and return $__intfactor{%r}; $c -= 4096 while $c % $r; return $__intfactor{%r}=$c; } # I'm lost by the meaning of your code, where is $s used? $r = 12; $s = 2*1024**3; print intfactor($c,$r);

Further optimizations can be made with a better search pattern:
http://en.wikipedia.org/wiki/Least_common_multiple


In reply to Re: Simple arithmetic? by cheako
in thread Simple arithmetic? by BrowserUk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.