Hi Monks,

I've just written some code to do the following:

$item will contain a string in the format 'X:Y'.
First I test if 'X:Y' exists in the hash, and if so, put the hash's value into $level.
Failing that, I test if 'X:*' exists in the hash, and if so, put the hash's value into $level.
Failing that, I test if '*' exists in the hash, and if so, put the hash's value into $level.
Failing that, I set $level = 0.

Here's the code I wrote to achieve the above: 

if ($level = $access{$item})  # Assignment & test for existance
{}   # Not very tidy looking, IMHO
elsif ($item =~ /^(.+):.+/ and $level = $access{"$1:*"} )  # Assignmen
+t & test for existance
{}   # Not very tidy looking, IMHO
else
{
  unless ($level = $access{'*'})  # Assignment & test for existance
  { $level = 0 }
}

[download]

The above code seems to be doing the job, and I'm not totally unhappy with it, but I'm wondering if there's a tidier or more concise way to write it, e.g. avoiding the empty '{}', and anything else you can suggest.

Note, the above was written without strict or warnings, and I'll be leaving it that way, despite the fact that it's against your religion. 8)

Thanks for your time.
Tel2

In reply to Tidy up conditions by tel2

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.