cheako:

If the first clause of an AND is false, or if the first clause of an OR is true, there's no reason for perl to evaluate the right side of the expression. Side effects in expressions often have issues like this.

In your case, it looks like you're just trying to pack too much stuff in a single conditional. When I look it over, I wonder what the heck it's doing. Yeah, I can figure it out, but I'd rather work on code that I can read, rather than decipher. Breaking it down into discrete units will make it simpler to read, and easier for you to debug, as well!

Update: I think your code is probably trying to do this (roughly):

our $cookingcounter = 350883;
our $garlicbreadheadstart = 600;
our $ovenempty = 0;

sub hold_time {
    my $cookingcounter = shift;

    return 0 if $ovenempty and !$test;

    my $holdtime = $cookingcounter + 60*90 - 356400;
    return $holdtime if $holdtime > 0;

    $holdtime = $cookingcounter + ($garlicbreadstart - 60 * (60+15)) -
+ 356400;
    return $holdtime if $holdtime > 0;

    return 0;
}

[download]

Update 2: After seeing hdb's response, I adjusted my code so it wouldn't return in test mode even when the oven is empty.

...roboticus

When your only tool is a hammer, all problems look like your thumb.

In reply to Re: Lazy conditional, skips assignment. by roboticus
in thread Lazy conditional, skips assignment. by cheako

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.