This isn't exactly a critique but some suggestions of how you might do a couple of your functions -
sub size_cmp($$) { return (stat($_[0]))[9] <=> (stat($_[1]))[9]; } sub get_files($) { return glob($_[0].'/*.{jpg,jpeg,gif,png}'); } sub main { $col=0; print "<table>\n<tr>\n"; @imgs = get_files($dir); for (@imgs) { print "\t<td width=\"200\">\n<img src="$Path/$_"></td>\n"; print "\n</tr>\n<tr>" if 0 == (3 % ++$col); } print "\n</tr>" if 0 != (3 % $col); print "</table>\nthere are ".@imgs." thumbs<br>\n"; }
Basically I just removed a bunch of hoops you were going through to get fairly trivial information (glob() is your friend :o)
Also, if you're doing HTML you may want to use here documents as they are enormously useful for making HTML in code readable. HTH

broquaint


In reply to Re: request criticism web page with images in dir (File::Find File::Spec) by broquaint
in thread request criticism web page with images in dir (File::Find File::Spec) by mandog

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.