Personally I would try not do this:

search_by_tags(split ',', $cgi->param('tags'));

because it does not take account of the possibility that there is no param "tags" and then you would be calling split on an undefined value. This isn't really bad in and of itself but it encourages the use of this pattern for other, potentially more dangerous operations than split which may have worse consequences. I'd pass the string/undef and let the sub check for undef and only then attempt the split. eg:

search_by_tags ($cgi->param('tags'));
#...
sub search_by_tags {
    my $tagstr = shift;
    return unless defined $tagstr;
    my @tags = split (/,/, $tagstr);
}

[download]

This also gives you the opportunity within the subroutine to raise an exception in the undef case which might be helpful.

In reply to Re: Which is better software design by hippo
in thread Which is better software design by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.