#use system command to add user and set passwd
system "useradd -m -p $d1 $d2";
Please do not do this. Ever.
- useradd requires escalated privileges
- You are not running in taint mode
- You have done no validation on $d1 or $d2
- There is no need for the shell at all here
and that's not even to consider that your choice of variable names ($d1, $d2) means that you have confused them.
Instead: use taint mode and strict, validate your input, give your variables meaningful names and use the exec form of system, eg: system('useradd', @args); If you are writing anything in perl which requires escalated privileges then do please read through all of perlsec first.
Security is always important. If you are giving the user a root shell, it becomes vitally important.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.