I wouldn't do this as a one-liner, but of course you can. But rather than loop through your IPs and check each of them against the other file (or vice versa), put the IPs in a hash, then go through the other file looking for IP patterns, check them against the hash, and comment them if they're found.

$ cat ips 111.222.333.444 55.66.77.88 $ cat text Line 1 nothing to comment Line 2 111.222.333.444 should be commented Line 3 11.22.33.44 do not comment Line 4 55.66.77.88 should be commented $ perl -pe '@l = `cat ips`;chomp @l; %h = map {$_=>1} @l; s/(\d{1,3}\. +\d{1,3}\.\d{1,3}\.\d{1,3})/$h{$1}?"#$1":$1/e;' <text

Aaron B.
Available for small or large Perl jobs and *nix system administration; see my home node.


In reply to Re: one liner with separate input file? by aaron_baugher
in thread one liner with separate input file? by MrGibbs

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.