porl:

The first thing I notice is that you're first initializing your @C array to 0, then you're initializing the first row and column to 0. Since they're already zero, you don't need that. So I'd remove those two loops.

Next, it looks like you're having trouble splitting up your strings. You can do it like so:

my @list_of_characters = split //, 'a string';

[download]

You're also using C-style loops, like so:

for(my $i = 0; $i<=$mLength; $i++) { ... }

[download]

You may find it easier to read if you'd switch over to a more perlish style, more like:

for my $i (0 .. $mLength) { ... }

[download]

You're also using '&' in a function call, which is something you ought to avoid except in certain cases. For general function calls, leave out the '&'.

You've got some off-by-one errors in wikiBacktrack: if $mLength holds the length of a array @m, then $m[$mLength] doesn't exist. If you want to check the value of the last item in the list, perl has a shorthand: -1 refers to the last item, so you can use that instead. (It also offers the $#m variable, which is the index of the last item if you need that value).

There are a few other items, but these should get you going.

Update: Added code tags so an array reference isn't treated as a link.

...roboticus

When your only tool is a hammer, all problems look like your thumb.

In reply to Re: LCS algorithm by roboticus
in thread LCS algorithm by porl

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.