(where does useSVG come from, for example)

Ah. That bit's gone from my version.

The library supports both SVG and VML, and useSVG is a global that is set either manually at the topmost level or by detecting the useragaent. I'm not interested in supporting old IEs, so I've already stripped all the useSVG and VML stuff out.

I've also separated out all the branches of the sub and at this point that sub reduces to:

function _OAV( oo,aa,vv ) { //Object, Attribute, Value
    oo.setAttribute( aa,vv );
}   

function fromOV( oo, vv ) {
    oo.setAttribute( "x1", vv.split( "," )[0] );
    oo.setAttribute( "y1", vv.split( "," )[1] );
}

function toOV( oo, vv ) {
    oo.setAttribute( "x2", vv.split( "," )[0] );
    oo.setAttribute( "y2", vv.split( "," )[1] );
}

function colorOV( oo, vv ) {
    oo.setAttribute( "fill", vv );
}

function innerTextOV( oo, vv ) {
    oo.firstChild.replaceData( 0, 108, vv );
}

[download]

Most of those will be inlined back into the main code; with only the fromOV() & toOV() which set two attributes left to deal with. The current practice of concatenating the two values together in the calling code and then splitting them in the functions will go. Not sure beyond that.

With the rise and rise of 'Social' network sites: 'Computers are making people easier to use everyday'
Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
"Science is about questioning the status quo. Questioning authority". I'm with torvalds on this
In the absence of evidence, opinion is indistinguishable from prejudice. Agile (and TDD) debunked

In reply to Re^4: Refactoring technique? by BrowserUk
in thread Refactoring technique? by BrowserUk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.