I am picking up IP address from a ifcfg file (RHEL) and trying to validate IP. But I am not able to validate it. When I am using IP address in quotes (e.g. ipaddress = "x.x.x.x" to check) it works but when I am trying to take it dynamically it does not 

#!/usr/bin/perl
use strict;
use warnings;
use Data::Validate::IP qw(is_ipv4);


print "Enter the absolute directory location for ifcfg files\n";
my $directory = <>;
chomp($directory);

opendir(DIR, $directory) or die "couldn't open $directory: $!\n";
my @ifcfg_files = grep { /^ifcfg-bond/ } readdir(DIR);
closedir DIR;


foreach (@ifcfg_files) {

my %hash = ();
my $file = "$_";

open (my $fh, "<", $file) or die "Can't open the file $file: ";


while (my $line =<$fh>)
{
    next if $. < 2;
    my($key, $parameter_value) = split("=", $line);
    next if $key eq "BONDING_OPTS";
    if (is_ipv4($parameter_value))
    {
      print $parameter_value;
    }
    else{
      print "Fail"
    }
}

} #Outer Foreach

Contents of ifcfg file

# Creating bond1
DEVICE=bond1
IPADDR=172.31.1.1
NETMASK=255.0.0.0
DNS1=172.30.12.25
MTU=
BOOTPROTO=none
ONBOOT=yes
USERCTL=NO
NM_CONTROLLED=no
BONDING_OPTS='mode=1 miimon=100'

Result

[root@localhost bond]# perl ifcfgbondverification.pl 
Enter the absolute directory location for ifcfg files
/root/office/ifcfgverification/bond
FailFailFailFailFailFailFailFailFailFailFailFailFailFailFailFailFailFa
+ilFailFailFailFailFailFailFailFailFailFailFailFailFailFailFailFailFai
+lFailFailFailFailFailFailFailFailFailFailFailFailFailFailFailFailFail
+FailFailFailFailFailFailFailFailFailFailFail[root@localhost bond]#

[download]

In reply to IP address validation when IP is picked dynamically by rahulruns

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.