If @ARGV is empty, then your call to shift gives you nothing: you then use nothing as an argument to split, which (quite justifiably) complains about the uninitialized value you just fed it.

To get around this, you could use an intermediate variable, thusly: 

my $addr = shift;
unless ($addr) {die $USAGE}
my ($username, $domain) = split /\@/, $addr;

[download]
alternatively, you could simply put in an early check to see if you have the correct number of arguments: 
die $USAGE unless @ARGV == 3; #or however many args you want

[download]

On the whole, I favor the first approach, as it lets you do a little more validation on the arguments (I sometimes just use my ($foo,$bar,$baz) = @ARGV myself), but if you're otherwise satisfied with your validation, the second method is an easy patch.

Update: fixed foolish typo (thanks, chipmunk!).


If God had meant us to fly, he would *never* have given us the railroads.
    --Michael Flanders

In reply to Re: Validating command-line _parameters_ (not options) by ChemBoy
in thread Validating command-line _parameters_ (not options) by dserodio

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.