This code looks pretty good, at least at a first glance. You use heredocs in some places, but not in others. It would be good to use them everywhere.

The biggest thing that jumps out is that you are not testing whether open succeeds or fails. Also, the data files appear to be in the same directory as the CGI script. This is definitely not a clever idea. Put them under your home directory, or something, but get them out from under the web document tree.

Finally, if you want to try this out on a webserver, if you ask jcwren nicely he'll give you an account on perlmonk.org.

--
g r i n d e r

In reply to Re: Monk Ladder by grinder
in thread Monk Ladder by jryan

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.