comment on

Nothing huge, but some cleanup things:

You don't ever use Time::Local. localtime is a built-in function.
You need my in front of your date/time variable list, to run under strict.
You don't need 'junk' variables ($j1, $j2, $j3) for the extra values from localtime. If your list on the left has fewer variables than are passed from the right, the extra ones will be discarded.
Your day and month adjustments can be done shorter and more cleanly with increment operators: $year += 1900; $mon++;
You should probably do error checking on your mkdir statements.
It's strange that you're opening your output files once, and then opening them again right away inside your subroutine. In fact, I'd almost expect that to cause an error or warning, but maybe Perl silently closes and re-opens it. Are you doing that so the first open (with '>') will start the files empty, and then switch to appending? It's probably unnecessary, but maybe you could explain your thinking there.
When you have multiple print statements in a row, you can often clean things up with a here-document:
```
print $html_report <<END;

#### Now Analyzing '$file_01_txt'

END
[download]
```
When you have "if(this){single_statement}" constructs, you can often eliminate much of the clutter of parens and brackets with postfix syntax:
```
 print $html_report "$line\n" if $line =~ /search criteria 01/i;
[download]
```

Aaron B.
Available for small or large Perl jobs and *nix system administration; see my home node.

In reply to Re: Perl File Parsing - My Code Works, but it's Ugly! by aaron_baugher
in thread Perl File Parsing - My Code Works, but it's Ugly! by Nico

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		`&`
	<		`<`
	>		`>`
	[		`[`
	]		`]`

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.