G'day keltan,

"Yes this is my homework but i dont need direct answers i appreciate tips."

Thanks for being upfront and honest about that (++). Here's some tips:

• Consider using the builtin module Getopt::Long for handling your command line arguments.
• Consider using the warnings pragma instead of the '-w' switch. The documentation explains why.
• The rename documentation points out some caveats:
  • The portability issues (rename in perlport) mentions "Win32" — 'D:\test' (in your code) indicates this may be relevant to you.
  • Consider the suggested, platform-independent move() function of the builtin module File::Copy.
• Avoid package variables for directory handles (DIR in your posted code is an example): these have global scope and suffer from the same problems as all global variables. Prefer lexical variables whose scope you can control — readdir shows a couple of usage examples.
  • Unrelated to your current question but, for future reference, and for the same reasons, avoid package variables for filehandles — open has examples using lexical filehandles.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.