I think that you should use a hash instead of an array to load file2, because a hash lookup is far more efficient than
greping through a full array for each line of file1. Something like this (untested):
use strict;
use warnings;
my $second_file = "npn.txt";
open my $fh2, '<', $second_file or die "Cannot open $second_file $!";
my %contents = map {chomp; $_ => 1} <$fh2>;
close $fh2;
my $first_file = "first_file.txt";
open my $fh1, '<', $first_file or die "Cannot open $first_file $!";
while( my $line = <$fh1>) {
chomp($line);
my $field2 = (split /,/, $line)[1];
print $line and next unless defined $field2;
print $line unless defined $contents{$field2};
}
close $fh1;
Please also take note of the way of opening files, considered to be more in line with commonly accepted best practices.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.