Hello ctrevgo_learn_perl, and welcome to the Monastery!

As graff says, you need to supply more information. For example, what is the format of a typical line read from the file “test.txt”? There seems to be some confusion:

# Strip the mbox and id, assuming the file contains mbox:id my($mbox,$id)=split(',',$_);

Aside from the fact that there is no stripping happening here, the comment specifies that the initial two items will be separated by a colon, but the code assumes a comma. If the comment is correct but the data line happens to contain a comma somewhere, this will “work” without warnings but will produce spurious results.

I note also that the script has:

use File::Slurp qw(read_dir); ... use Data::Dumper;

but neither module appears to be actually used?

And an observation on style. The use constant declarations can be written more clearly, like this:

use constant { DRY => 1, # Dry run. 0 will execute FILE => 'test.txt', # Hardcoding the file path as + of now STATS_FILE => 'mbox_stats.txt', # Successful operation - stat +s file MBOX_UNKNOWN => 'mbox_unknown.txt', # Failed mailbox operations VOL => '/home/folder/', # TOP Level volume directory DEBUG => 1, };

Hope that helps,

Athanasius <°(((><contra mundum Iustus alius egestas vitae, eros Piratica,


In reply to Re: Increase script speed by Athanasius
in thread Increase script speed by ctrevgo_learn_perl

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.