Instead of your current while loop try this one which should be somewhat faster.
I replaced your first regular expressions with a "substr eq"
combination.
my $dir='/acm/';
my $strlen=length ($dir)
while (<LOG>) {
my $url = (split())[6];
if ((substr($url,0,$strlen) eq $dir) && ($url=~/$error/)) {
if (exists $report{$url}) {
$report{$url}++;
} else {
$report{$url} = 1;
}
}
}
I benchmarked this using some sample data I made up
and it is about %35 faster
than the original version. Your performance may vary.
Regular-expressions are slower than straight
string operations. So if you can accomplish what you want with string operations
and performance matters, then you can tune your code by replacing
some regular-expressions with string operations (only feasible for
simple regular-expressions).
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.