You are computing every distance twice. It probably is better to keep your results in an array and take advantage of symmetry. 
use strict;
use warnings;
use Data::Dumper;
my @data;
while (<DATA>) {
    next if !/\S/;
    push @data, [split];
}

my @array;
for my $i (0..$#data) {
    $array[$i][$i] = 0;
    for my $j ($i+1..$#data) {
        $array[$j][$i] = $array[$i][$j] = distance( $data[$i], $data[$
+j] );
    }
}
print Dumper( \@array );
 
sub distance {
    my ($p1, $p2) = @_;
    return sqrt (
          ($p1->[0] - $p2->[0]) ** 2
        + ($p1->[1] - $p2->[1]) ** 2
        + ($p1->[2] - $p2->[2]) ** 2
    );
}
__DATA__
1 1 1
2 2 2
3 3 3
4 4 4
5 5 5

[download]
Bill

In reply to Re: Subroutine not correct (I think) by BillKSmith
in thread Subroutine not correct (I think) by jcklasseter

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.