Hi Pharazon,

I can't really comment at all on the way you use of the PDF modules you are using, I don't know them.

But, overall, I find your Perl code well written, well structured, clean and sensible, sometimes even idiomatic, usually in agreement with the coding good practices generally accepted by the Perl Community.

The only thing that I am wondering about, but this may be my lack of knowledge of the PDF modules, is that you don't seem to worry about error checking when you open a new PDF file or do other similar OS operations. Again, I don't know these modules, but I would tend to think that you probably need to check if you failed to open a file and to do something about it if such is the case.

So, to me, yes, you are on the right track, with the possible exception of error checking.


In reply to Re: Am I on the right track? by Laurent_R
in thread Am I on the right track? by Pharazon

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.