Hello born_Today, and welcome to the Monastery!

First, you should always begin your scripts with:

use strict; use warnings;

and declare variables with my. You should also test every open and close statement for success, either explicitly, or by adding:

use autodie;

to the head of your script.

Now, your second while loop does nothing, because at the end of the first loop the filehandle FILE is pointing to the end of the file. You could seek to the beginning, but actually there is no need for the second loop — just include the logic for string2 in the first loop. Like this (untested):

use strict; use warnings; use autodie; my @files = <C:/temp/CHOP/*JUNE*>; for my $file (@files) { my $count = 0; open(my $fh, '<', $file); print "=====$file=====\n"; while (my $line = <$fh>) { if ($line =~ /Total/) { print $line; } elsif ($line =~ /failed/) { ++$count; } } close $fh; print "Total Volume Failed to Resolve: $count\n" ; }

Note that I have converted FILE into the lexical variable $fh, and used the 3-argument form of open. I have also replaced the %count hash with a simple scalar, which seems to be all that is needed.

Hope that helps,

Athanasius <°(((><contra mundum Iustus alius egestas vitae, eros Piratica,


In reply to Re: Process multiple files in a directory by Athanasius
in thread Process multiple files in a directory by born_Today

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.