Welcome to PerlMonks!

You should always use strict; and use warnings; at the top of every Perl script. It pinpoints the vast majority of things that are wrong (or could be better) up front, so it forces you to write more predictable, stable code.

Here's an example of what I think you want to do, using strict, warnings and common Perl idioms. It seems you only want to have a total count, so I got rid of the hash as it isn't needed.

#!/usr/bin/perl use warnings; use strict; my @files = <C:/temp/CHOP/*JUNE*>; for my $file (@files){ open my $fh, '<', $file or die "Can't open file $file: $!"; my $count = 0; while (my $line = <$fh>){ print "$line" if $line =~ /Total/; $count++ if $line =~ /failed/; } if ($count){ print "Total Volume Failed to Resolve in $file: $count\n"; } }

Notice that if 'Total' and 'failed' are on the same line, it counts as a 'Total' due to the first if statement. If you want it to fail even though the line contains 'Total':

if ($line =~ /Total/ and $line != /failed/){ print "$line\n"; }

-stevieb


In reply to Re: Process multiple files in a directory by stevieb
in thread Process multiple files in a directory by born_Today

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.