Hello Monk::Thomas,
Finally I understood your comments, I was not able to understand that you first need to check if the port number is actually is an Integer:
if (defined $value and $value =~ /\A (\d+) \z/xms)
Well a few things that I noticed is that you need to modify the second condition from:
if ($MIN_TCP_PORT <= $port and $port <= $MAX_TCP_PORT)to:
if ($MIN_TCP_PORT <= $port and $port >= $MAX_TCP_PORT)The port should not be greater than the MAX_TCP_PORT not minor. ;)
Question, why are you assigning the $value to a new value $port = $1. Is there a specific reason?
Last modification that I applied on my updated version, is the port. You are right just by modifying the hash would not be clear to someone else on the future.
So I added a simple or condition when I am creating the socket. Sample of modification:
PeerPort => $moduleInput{-port} || DEFAULT_NTP_PORT, # Default NTP por +t 123
Again thank you for your time and effort reviewing my code.
In reply to Re^6: RFC: Net::SNTP::Client v1
by thanos1983
in thread RFC: Net::SNTP::Client v1
by thanos1983
| For: | Use: | ||
| & | & | ||
| < | < | ||
| > | > | ||
| [ | [ | ||
| ] | ] |