Hello kanskr,

I noticed a few issues with your code, see my edits/additions below. I put your example data in a file called report.txt and tested your script using it. I get the same errors. I printed your hash using Data::Dumper, which made troubleshooting easier. However, it can still be difficult to see problematic extra white space.

• The input data you provided seems to have random spaces before or after some fields. You need to ensure that your input data is more consistently formatted, or you need to adjust your code to tolerate the extra spaces. Using,

  split(/\s*\|\s*/, $line)

  will remove the spaces from your parsed data.
• In your foreach loop, you are attempting to use hash keys of Added and Deleted; however, your data (and therefore your hash) contains added and deleted. The case of your string matters.
• You are getting the Can't use an undefined value as an ARRAY reference error, because the added and/or deleted hash key does not exist for some usernames. So, instead of checking for empty values like this:

  @{$k{$_}{added}} ne ''

  I suggest that you check that the value exists, like this:

  exists($k{$_}{added})

• This line appears to contain typos:

  print "${k{user}}\n";

  so I removed it from the code.

This code,

use strict;
use warnings;
use diagnostics;
use Data::Dumper;

open(FIL,"report.txt") or die("$!");

my %k=();

while (my $line=<FIL>) {
      next if $. < 2;
        my ($user,$roles,$type,$dt,$empty1,$empty2)=split(/\s*\|\s*/,$
+line);

        push @{$k{$user}{$type}}, $roles;

}

my @names = sort keys(%k);

# Dumping the reference to the hash to more clearly show its structure
+ 
print Dumper \%k; 

foreach ( @names ) {
   print "Name: ", $_, "\n";
       if( exists($k{$_}{added}) ){

           print "\tAdded:\n\t\t";
           print   join ',', @{$k{$_}{added}};
           print "\n";
       }
       if ( exists($k{$_}{deleted}) ) {
           print "\tDeleted:\n\t\t";
           print join ',', @{$k{$_}{deleted}};
           print "\n";
       }
}
[download]

gives the following output:

$VAR1 = {
          'cdf' => {
                     'added' => [
                                  'deploy'
                                ]
                   },
          'xyz' => {
                     'deleted' => [
                                    'admin',
                                    'deploy'
                                  ]
                   },
          'abc' => {
                     'added' => [
                                  'admin',
                                  'deploy'
                                ],
                     'deleted' => [
                                    'developer'
                                  ]
                   }
        };
Name: abc
    Added:
        admin,deploy
    Deleted:
        developer
Name: cdf
    Added:
        deploy
Name: xyz
    Deleted:
        admin,deploy
[download]

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.