comment on

Okay, going back to the script and HTML file as written at http://www.sitepoint.com/uploading-files-cgi-perl/the upload now works on my site.

I have family commitments for tonight for Independence Day, so I will pick this up as opportunity permits. I would recommend you proceed thus:

Take these two files, adjust only what is needed to make it work on your site -- no functionality changes.
Add one feature from your version at a time, testing each as you go.
- Don't get in a hurry.
- Add the module but no other code changes -- make sure something isn't getting exported which is killing you.
- If just adding module causes no behavior changes, only then proceed. Make small changes for feature addition, and keep re-testing. Find out which piece breaks it.

The HTML file:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "DTD/xhtml1-s
+trict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>File Upload</title>
</head>
<body>
<form action="/cgi-bin/photup20a.pl" method="post" enctype="multipart/
+form-data">
<p>Photo to Upload: <input type="file" name="photo" /></p>
<p>Your Email Address: <input type="text" name="email_address" /></p>
<p><input type="submit" name="Submit" value="Submit Form" /></p>
</form>
</body>
</html>
[download]

The Perl script:

#!/usr/bin/perl -wT

use strict;
use CGI;
use CGI::Carp qw ( fatalsToBrowser );
use File::Basename;

$CGI::POST_MAX = 1024 * 5000;
my $safe_filename_characters = "a-zA-Z0-9_.-";
my $upload_dir               = ".";

my $query         = new CGI;
my $filename      = $query->param("photo");
my $email_address = $query->param("email_address");

if ( !$filename ) {
    print $query->header();
    print "There was a problem uploading your photo (try a smaller fil
+e).";
    exit;
}

my ( $name, $path, $extension ) = fileparse( $filename, '..*' );
$filename = $name . $extension;
$filename =~ tr/ /_/;
$filename =~ s/[^$safe_filename_characters]//g;

if ( $filename =~ /^([$safe_filename_characters]+)$/ ) {
    $filename = $1;
}
else {
    die "Filename contains invalid characters";
}

my $upload_filehandle = $query->upload("photo");

open( UPLOADFILE, ">$upload_dir/$filename" ) or die "$!";
binmode UPLOADFILE;

while (<$upload_filehandle>) {
    print UPLOADFILE;
}

close UPLOADFILE;

print $query->header();
print <<END_HTML;
 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "DTD/xhtml1-
+strict.dtd">
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
 <head>
 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
 <title>Thanks!</title>
 <style type="text/css">
 img {border: none;}
 </style>
 </head>
 <body>
 <p>Thanks for uploading your photo!</p>
 <p>Your email address: $email_address</p>
 <p>Your photo:</p>
 <p><img src="./$filename" alt="Photo" /></p>
 </body>
 </html>
END_HTML

__END__
[download]

In reply to Re: File Upload On Windows 8 and Perl by marinersk
in thread File Upload On Windows 8 and Perl by skosterow

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		`&`
	<		`<`
	>		`>`
	[		`[`
	]		`]`

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.