s0ttle has the rewrite correct. However, Perl idiom (and tradional coding practice) would dictate declaring a variable in tightest scope possible. Thus, I moved the
my to within the
while loop.
#!/usr/bin/perl -w
# IP ranger
# If you're on 5.6.0 or higher, add the following two lines
# and remove the -w
#use 5.6.0;
use strict;
#use warnings;
open(IPFILE,"<iplist.txt"); # open readonly
|| die "Could not open iplist.txt:$! \n";
while (<IPFILE>) {
chomp;
my ($stip,$edip) = split ':', $_, 2; # split(/:/);
print "$stip\n";
print "$edip\n";
my @openip = split '.', $stip; # split(/\./,$stip);
my $count = @openip;
print "$count\n";
# you can avoid the creation of the $count
# variable and use the following statement
# print scalar(@openip), "\n";
# for ($i = 0; $i <= 4; $i++) {
# print "@srtip\n";
# };
};
close(IPFILE);
------
We are the carpenters and bricklayers of the Information Age.
Don't go borrowing trouble. For programmers, this means Worry only about what you need to implement.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.